Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FLYWOOH743PRO #569

Merged
merged 7 commits into from
Oct 25, 2024
Merged

Add FLYWOOH743PRO #569

merged 7 commits into from
Oct 25, 2024

Conversation

haslinghuis
Copy link
Member

No description provided.

@haslinghuis haslinghuis marked this pull request as draft September 10, 2024 10:47
@haslinghuis haslinghuis marked this pull request as ready for review September 27, 2024 19:32
@haslinghuis haslinghuis requested a review from ot0tot October 11, 2024 16:18
@haslinghuis haslinghuis requested review from KarateBrot and nerdCopter and removed request for nerdCopter October 11, 2024 16:42
@haslinghuis haslinghuis requested a review from sugaarK October 23, 2024 14:07
TIMER_PIN_MAP(12, LED_STRIP_PIN, 1, 0) \
TIMER_PIN_MAP(13, RX_PPM_PIN , 2, -1)

#define ADC1_DMA_OPT 8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do these need defining with the DMA controller?

Copy link
Member

@KarateBrot KarateBrot Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is just copied over from another target. I did that as well for a H743 config but as it turned out it was wrong.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very common setting:

src/config/configs/SPRACINGH7EF/config.h:162:#define ADC3_DMA_OPT                  10
src/config/configs/FOXEERH743V2/config.h:107:#define ADC1_DMA_OPT 8
src/config/configs/FOXEERH743V2/config.h:108:#define ADC2_DMA_OPT 9
src/config/configs/FOXEERH743V2/config.h:109:#define ADC3_DMA_OPT 10
src/config/configs/IFLIGHT_H743_AIO/config.h:92:#define ADC1_DMA_OPT 8
src/config/configs/IFLIGHT_H743_AIO/config.h:93:#define ADC3_DMA_OPT 9
src/config/configs/SPRACINGH7EVO/config.h:122:#define ADC3_DMA_OPT                  10
src/config/configs/MINI_H743_HD/config.h:119:#define ADC1_DMA_OPT        8
src/config/configs/MINI_H743_HD/config.h:120:#define ADC2_DMA_OPT        9
src/config/configs/MINI_H743_HD/config.h:121:#define ADC3_DMA_OPT       10
src/config/configs/NEUTRONRCH7BT/config.h:121:#define ADC1_DMA_OPT        8
src/config/configs/NEUTRONRCH7BT/config.h:122:#define ADC3_DMA_OPT        9
src/config/configs/IFLIGHT_H7_TWING/config.h:103:#define ADC1_DMA_OPT        8
src/config/configs/IFLIGHT_H7_TWING/config.h:104:#define ADC3_DMA_OPT        9
src/config/configs/JHEH743_HD/config.h:123:#define ADC1_DMA_OPT 8
src/config/configs/JHEH743_HD/config.h:124:#define ADC3_DMA_OPT 9
src/config/configs/MAMBAH743/config.h:114:#define ADC1_DMA_OPT        8
src/config/configs/MAMBAH743/config.h:115:#define ADC3_DMA_OPT        9
src/config/configs/SDMODELH7V2/config.h:105:#define ADC1_DMA_OPT        8
src/config/configs/SDMODELH7V2/config.h:106:#define ADC3_DMA_OPT        9
src/config/configs/MATEKH743/config.h:138:#define ADC1_DMA_OPT        8
src/config/configs/MATEKH743/config.h:139:#define ADC3_DMA_OPT        9
src/config/configs/SPRACINGH7NANO/config.h:106:#define ADC1_DMA_OPT            8
src/config/configs/SPRACINGH7NANO/config.h:107:#define ADC3_DMA_OPT            9
src/config/configs/IFLIGHT_H743_AIO_V2/config.h:106:#define ADC1_DMA_OPT        1
src/config/configs/IFLIGHT_H743_AIO_V2/config.h:107:#define ADC2_DMA_OPT        9
src/config/configs/IFLIGHT_H743_AIO_V2/config.h:108:#define ADC3_DMA_OPT       10
src/config/configs/SPRACINGH7EXTREME/config.h:111:#define ADC1_DMA_OPT 8
src/config/configs/SPRACINGH7EXTREME/config.h:112:#define ADC3_DMA_OPT 9
src/config/configs/SPRACINGH7EXTREME/config.h:226:#define ADC1_DMA_OPT        8
src/config/configs/SPRACINGH7EXTREME/config.h:227:#define ADC3_DMA_OPT        9
src/config/configs/TMOTORH743/config.h:122:#define ADC1_DMA_OPT                    8
src/config/configs/TMOTORH743/config.h:123:#define ADC3_DMA_OPT                    9
src/config/configs/KAKUTEH7/config.h:100:#define ADC1_DMA_OPT        8
src/config/configs/KAKUTEH7/config.h:101:#define ADC3_DMA_OPT        9
src/config/configs/KAKUTEH7V2/config.h:96:#define ADC1_DMA_OPT        8
src/config/configs/KAKUTEH7V2/config.h:97:#define ADC3_DMA_OPT        9
src/config/configs/SEQUREH7/config.h:99:#define ADC1_DMA_OPT 8
src/config/configs/SEQUREH7/config.h:100:#define ADC3_DMA_OPT 9
src/config/configs/MAMBAH743_2022B/config.h:114:#define ADC1_DMA_OPT        8
src/config/configs/MAMBAH743_2022B/config.h:115:#define ADC3_DMA_OPT        9
src/config/configs/SPRACINGH7ZERO/config.h:119:#define ADC1_DMA_OPT            8
src/config/configs/SPRACINGH7ZERO/config.h:120:#define ADC3_DMA_OPT            9
src/config/configs/KAKUTEH7MINI/config.h:100:#define ADC1_DMA_OPT        8
src/config/configs/KAKUTEH7MINI/config.h:101:#define ADC3_DMA_OPT        9
src/config/configs/SPRACINGH7RF/config.h:125:#define ADC3_DMA_OPT                  10
src/config/configs/SKYSTARSH7HD/config.h:123:#define ADC1_DMA_OPT        8
src/config/configs/SKYSTARSH7HD/config.h:124:#define ADC3_DMA_OPT        9
src/config/configs/SEQUREH7V2/config.h:100:#define ADC1_DMA_OPT 8
src/config/configs/SEQUREH7V2/config.h:101:#define ADC3_DMA_OPT 9
src/config/configs/FLYWOOH743PRO/config.h:119:#define ADC1_DMA_OPT        8
src/config/configs/FLYWOOH743PRO/config.h:120:#define ADC3_DMA_OPT        9
src/config/configs/SDMODELH7/config.h:98:#define ADC1_DMA_OPT 8
src/config/configs/SDMODELH7/config.h:99:#define ADC3_DMA_OPT 9
src/config/configs/SAKURAH743/config.h:157:#define ADC1_DMA_OPT        8
src/config/configs/SAKURAH743/config.h:158:#define ADC3_DMA_OPT        9
src/config/configs/CHONKERH735/config.h:109:#define ADC1_DMA_OPT                    8
src/config/configs/CHONKERH735/config.h:110:#define ADC3_DMA_OPT                    9
src/config/configs/NEUTRONRCH743AIO/config.h:116:#define ADC1_DMA_OPT        8
src/config/configs/NEUTRONRCH743AIO/config.h:117:#define ADC3_DMA_OPT        9
src/config/configs/2RAW_THUNDER_H7/config.h:112:#define ADC1_DMA_OPT        8
src/config/configs/2RAW_THUNDER_H7/config.h:113:#define ADC3_DMA_OPT        9
src/config/configs/TMH7/config.h:107:#define ADC1_DMA_OPT        8
src/config/configs/TMH7/config.h:108:#define ADC3_DMA_OPT        9
src/config/configs/IFLIGHT_BLITZ_H7_PRO/config.h:121:#define ADC1_DMA_OPT        8
src/config/configs/IFLIGHT_BLITZ_H7_PRO/config.h:122:#define ADC3_DMA_OPT        9
src/config/configs/BETAFPVH743/config.h:111:#define ADC1_DMA_OPT        1
src/config/configs/BETAFPVH743/config.h:112:#define ADC2_DMA_OPT        9
src/config/configs/BETAFPVH743/config.h:113:#define ADC3_DMA_OPT       10
src/config/configs/JHEH743_AIO/config.h:107:#define ADC1_DMA_OPT        8
src/config/configs/JHEH743_AIO/config.h:108:#define ADC3_DMA_OPT        9
src/config/configs/FOXEERH743/config.h:105:#define ADC1_DMA_OPT                    8
src/config/configs/FOXEERH743/config.h:106:#define ADC2_DMA_OPT                    9
src/config/configs/FOXEERH743/config.h:107:#define ADC3_DMA_OPT                    10
src/config/configs/AOCODARCH7DUAL/config.h:122:#define ADC1_DMA_OPT        8
src/config/configs/AOCODARCH7DUAL/config.h:123:#define ADC3_DMA_OPT        9

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if IFLIGHT_H743_AIO_V2 and BETAFPVH743 seems to be wrong here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn’t answer my question.. with the dma controller it’s better to let it assign dma channels

@blckmn blckmn merged commit 6647698 into betaflight:master Oct 25, 2024
1 check passed
@haslinghuis haslinghuis deleted the add-flywooh743pro branch October 25, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants